Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filedialog: persistent file filter, add separate models filter #753

Merged
merged 3 commits into from
Jun 2, 2016
Merged

Filedialog: persistent file filter, add separate models filter #753

merged 3 commits into from
Jun 2, 2016

Conversation

hg42
Copy link
Contributor

@hg42 hg42 commented Jun 2, 2016 •
edited
Loading

I didn't like the FileDialog defaulting to gcode.
see #736 :

I think, there are two kinds of users:

  • slicing first and then loading gcode file into Printrun
  • having a slicer configured in Printrun and therefore loading STL/OBJ models

I also added a filter for "only model files" complementing the "only gcode files" filter

EDIT: I managed to make the filter persistent, so all users should be happy now :-)

@hg42 hg42 changed the title Filedialog add models filter and default to all known Filedialog add models filter and default to model and gcode files Jun 2, 2016
@hg42 hg42 changed the title Filedialog add models filter and default to model and gcode files Filedialog: add separate models filter and default to model and gcode files Jun 2, 2016
@hg42 hg42 changed the title Filedialog: add separate models filter and default to model and gcode files Filedialog: add separate models filter, default to both, make filter default persistent Jun 2, 2016
@kliment
Copy link
Owner

kliment commented Jun 2, 2016

Perfect, I like this solution a lot.

@kliment kliment merged commit 5d6f191 into kliment:master Jun 2, 2016
@hg42 hg42 changed the title Filedialog: add separate models filter, default to both, make filter default persistent Filedialog: persistent file filter, add separate models filter Jun 2, 2016
@hg42
Copy link
Contributor Author

hg42 commented Jun 2, 2016

thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hg42 @kliment