Add documentation and unit tests for printcore #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error "AttributeError: 'RuntimeError' object has no attribute 'errno'"
Close socket connection before removing the reference to it. Otherwise we get warning "ResourceWarning: unclosed <socket.socket [...]>" meaning that the underlying system resource (e.g. a file descriptor) remains allocated.
|
If no one argues against it I will merge this PR along with #1333 next week :) |
|
@rockstorm101 which AI generated this? |
Hahahaha, I wish I could say it was done by an AI and it only took 5 minutes but I'm afraid it was me who wrote this and it took me ages :P (hence why this might introduce some regression bugs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first this PR tries to add more documentation and some unit tests to
printrun/printcore.py. As a collateral, the functionality ofprintrun/printereventhandler.pyis also tested.This testing highlighted some issues with the current
printcore.pycode which I've tried to address as well on separate commits.This PR does not break (as far a I know) the current API. However, a thorough review would be more than welcome. I hope the testing logic is not too obfuscated.
This is also a first step in preparation for a printcore code refactoring. I'll submit that once we are happy with this PR.
As always, any comments/suggestions are appreciated and I'll be happy to address them.