Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a perspective transform option, render gcode views with perspective transform #1240

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

kliment
Copy link
Owner

@kliment kliment commented Jan 24, 2022

When the perspective option in settings->options->viewer is enabled, renders the gcode viewer with a perspective transform instead of an isometric transform. Fixes #1239

@kliment kliment requested a review from volconst January 24, 2022 11:10
@volconst
Copy link
Collaborator

@kliment , I do not feel competent here, so I trust your judgement :)

@kliment
Copy link
Owner Author

kliment commented Jan 24, 2022

@volconst it works okay for me, but I wanted someone else to check it to make sure I haven't missed some obvious breakage that isn't obvious on my setup

@volconst
Copy link
Collaborator

I will try to run it in the next 2 hours.

@kliment
Copy link
Owner Author

kliment commented Jan 24, 2022

No hurry, it can wait

@volconst
Copy link
Collaborator

@kliment , works fine on Ubuntu 20.04

@kliment
Copy link
Owner Author

kliment commented Jan 24, 2022

As it's off by default I'll merge it for now, and then we can consider whether we want it on by default

@kliment kliment merged commit ecd6c7c into master Jan 24, 2022
@kliment kliment deleted the perspective-transform branch January 24, 2022 21:50
@volconst
Copy link
Collaborator

volconst commented Jan 24, 2022

It's nice to see how slicers do it.
I looked at an year old Cura, and they use perspective view. Not sure if it can be switched.
My intuition is that orthogonal is better, because it is more suitable for plate layouting. But maybe people spend more time not layouting, but waiting for the printer to finish the print :)
If so, after print button is pressed it should go to perspective - just kidding :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering on the viewer
2 participants