Revised: Full Pronterface graph colour configuration #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sigma-One I'll merge this PR, which contains your original commit, and close #1205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes on top of Sigma-One PR #1205
So that:
The gray color stays, even if it may never be displayed.
Temperature Line color settings are RGBA (transparent) as were the magic constants they replace.
The picker of the color picker does not support alpha color yet (wxpython 4.1.1 does with a new window style), but the text edit supports it.
This PR includes the changes of #1205, if this PR is merged, #1205 should be dismissed.
Sigma-One will need to erase the RGB settings in his ~/.config/Printrun/pronsolerc file.