Projector fix, race condition fix #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendering did not work, probably since python3. Default first layer timeout of -1 was ignored
Make grouped controls children of the group title control so tooltips work in GTK. Remove context help button as tooltips show automatically Invoke Fit() after frame hierarchy is visualized to reveal whole Info group in GTK.
M110 requires 'ok' confirm, but set it to be required before send() to ensure send() does not finish before set and the 'ok' be skipped worthless. Fixes kliment#1124. Thanks to @SokobanRyu for reporting and coding patch.
kliment
approved these changes
Jan 25, 2021
|
@volconst I'm happy with this, feel free to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1140 #1124