Reimplement arc interpolation by yielding new InterpolationPoints #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8dfc633 to
e06d600
Compare
|
@volconst looks like this was your suggestion, and looks good to me. What do you think? |
volconst
reviewed
Aug 22, 2020
| avg_move_normal_y = move_normal_y | ||
| for point in interpolate_arcs(gline, prev_gline): | ||
| current_pos = (point.current_x, point.current_y, point.current_z) | ||
| if not gline.extruding: |
There was a problem hiding this comment.
I do not understand why bother to define InperpolationPoint to immediately convert it to tuple current_pos on the next line instead of just returning tuple.
|
@kliment It's ok to commit. |
|
Looks great, thank you, @IgorYeremin |
|
Merged, thanks @IgorYeremin @volconst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1092
Very ugly diff because of indentation, use &w=1 in github url or --ignore-space-change in git diff