Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize moves with laser/spindle active as extrusion #1094

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

IgorYeremin
Copy link
Contributor

No description provided.

@@ -904,6 +904,7 @@ def _add_settings(self, size):
self.settings._add(BooleanSetting("clamp_jogging", False, _("Clamp manual moves"), _("Prevent manual moves from leaving the specified build dimensions"), "Printer"))
self.settings._add(BooleanSetting("display_progress_on_printer", False, _("Display progress on printer"), _("Show progress on printers display (sent via M117, might not be supported by all printers)"), "Printer"))
self.settings._add(SpinSetting("printer_progress_update_interval", 10., 0, 120, _("Printer progress update interval"), _("Interval in which pronterface sends the progress to the printer if enabled, in seconds"), "Printer"))
self.settings._add(BooleanSetting("cutting_as_extrusion", False, _("Display cutting moves"), _("Show moves where spindle is active as printing moves"), "Printer"))
self.settings._add(ComboSetting("uimode", _("Standard"), [_("Standard"), _("Compact"), ], _("Interface mode"), _("Standard interface is a one-page, three columns layout with controls/visualization/log\nCompact mode is a one-page, two columns layout with controls + log/visualization"), "UI"), self.reload_ui)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgorYeremin , In your practice with such machines, isn't cutting_as_extrusion == True the default setting?
When would one want to have it disabled - except that it has been always disabled being not implemented till now?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also support this being true by default - @IgorYeremin what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm ok with making it on by default. I made it opt-in in case someone was abusing spindle commands for controlling something else on their printer. That should be a very small group of people and they can uncheck the box.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgorYeremin Great, can you make the change and then I'll merge?

@kliment kliment merged commit 1b892d5 into kliment:master Aug 20, 2020
@IgorYeremin IgorYeremin deleted the visualize-cut-moves branch August 20, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants