FIx a crash when starting pronterface due to locale settings #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting pronterface on Windows 10 (1903 18362.296), wxWidgets
throws an error due to inconsistent locale settings:
Traceback (most recent call last):
File "pronterface.py", line 62, in <module>
app = PronterApp(False)
File "Printrun\printrun\pronterface.py", line 2396, in __init__
self.mainwindow = PronterWindow(self)
File "Printrun\printrun\pronterface.py", line 187, in __init__
self.SetIcon(wx.Icon(iconfile("pronterface.png"), wx.BITMAP_TYPE_PNG))
wx._core.wxAssertionError: C++ assertion "strcmp(setlocale(LC_ALL, NULL), "C") == 0" failed at ..\..\src\common\intl.cpp(1579) in wxLocale::GetInfo(): You probably called setlocale() directly instead of using wxLocale and now there is a mismatch between C/C++ and Windows locale.
Fix this issue by specifying the locale on the pronterface app using wxLocale,
as suggested by the assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting pronterface on Windows 10 (1903 18362.296), wxWidgets
throws an error due to inconsistent locale settings:
Traceback (most recent call last):
File "pronterface.py", line 62, in
app = PronterApp(False)
File "Printrun\printrun\pronterface.py", line 2396, in init
self.mainwindow = PronterWindow(self)
File "Printrun\printrun\pronterface.py", line 187, in init
self.SetIcon(wx.Icon(iconfile("pronterface.png"), wx.BITMAP_TYPE_PNG))
wx._core.wxAssertionError: C++ assertion "strcmp(setlocale(LC_ALL, NULL), "C") == 0" failed at ....\src\common\intl.cpp(1579) in wxLocale::GetInfo(): You probably called setlocale() directly instead of using wxLocale and now there is a mismatch between C/C++ and Windows locale.
Fix this issue by specifying the locale on the pronterface app using wxLocale,
as suggested by the assertion.