Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Clicking "+Z⇑" or "-Z⇓" throws a bogus error #908

Closed
VanessaE opened this issue Mar 10, 2018 · 2 comments
Closed

[2.x] Clicking "+Z⇑" or "-Z⇓" throws a bogus error #908

VanessaE opened this issue Mar 10, 2018 · 2 comments

Comments

@VanessaE
Copy link
Contributor

VanessaE commented Mar 10, 2018

Traceback (most recent call last):
  File "/home/vanessa/RepRap/Printrun-2.x/printrun/gui/zbuttons.py", line 149, in OnLeftDown
    if r >= 0:
TypeError: unorderable types: NoneType() >= int()

I refer to the extreme top and bottom of the Z axis jog control. Obviously the ends of the axis should do nothing since the actual Z controls are the three buttons below and above those spots. 😄

@VanessaE VanessaE changed the title Clicking "+Z⇑" or "-Z⇓" throws a bogus error [2.x] Clicking "+Z⇑" or "-Z⇓" throws a bogus error Mar 10, 2018
@hroncok
Copy link
Collaborator

hroncok commented Mar 10, 2018

Note that comparing different types was possible in legacy Python but it's not possible now.

hroncok added a commit to hroncok/Printrun that referenced this issue Mar 10, 2018
In Python 2, None >= 0 was False. Now it's TypeError.
@hroncok hroncok mentioned this issue Mar 10, 2018
@hroncok
Copy link
Collaborator

hroncok commented Mar 10, 2018

#910

kliment added a commit that referenced this issue Mar 10, 2018
@kliment kliment closed this as completed Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants