Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support the T? G-code #888

Closed
bubnikv opened this issue Feb 13, 2018 · 18 comments
Closed

Please support the T? G-code #888

bubnikv opened this issue Feb 13, 2018 · 18 comments

Comments

@bubnikv
Copy link

bubnikv commented Feb 13, 2018

Hello.

Our Prusa i3 MK2 Multi-Material firmware based on the Marlin firmware understands a new G-code: T? instructs the firmware to ask user to select the spool to print from. We have an error report, that pronterface does not understand the T? G-code and it refuses to print.

prusa3d/PrusaSlicer#680

Would you please add a support for the new T? G-code?
Thank you.

@rockstorm101
Copy link
Collaborator

Hi, could you please provide a simple example gcode file using command "T?" so we can play around with it?

Thanks

@bubnikv
Copy link
Author

bubnikv commented Feb 14, 2018

Sure. Here is an example, generated with the Slic3r Prusa Edition for the "Original Prusa i3 MK2 MM Single Mode" Printer profile.

20mmbox.zip

Thanks for your attention.

@kliment
Copy link
Owner

kliment commented Mar 19, 2018

Hey, this was a two line change, I implemented it in both master and the 2.x (py3/wxp4) branch. @bubnikv, can you verify this works for you?

@FidelCapo
Copy link

@kliment I tested it on our multi-printer printer and everything went well. Thanks for your implementation.

@kliment
Copy link
Owner

kliment commented Mar 20, 2018

Awesome. If you're in a position to do so, testing of the 2.x branch would be greatly appreciated (not just for this issue, but also in general). I'm closing this issue as resolved.

@kliment kliment closed this as completed Mar 20, 2018
@bubnikv
Copy link
Author

bubnikv commented Mar 20, 2018 via email

@FidelCapo
Copy link

@klimenti Would it be possible to provide a compiled last version of pronterface for win? Thanks

@kliment
Copy link
Owner

kliment commented Mar 20, 2018

Only after the 2.0 release is done. I need to redo the windows build/packaging process.

@FidelCapo
Copy link

OK, Thank you

@kliment
Copy link
Owner

kliment commented Mar 23, 2018

I made the slic3r integration in printrun detect and handle slic3rPE config files (for whatever reason they're in a separate location from normal slic3r configs, and I was testing how slic3r integration deals with missing config files, and noticed this). I have a binary build setup now for Windows and OSX, so I'll probably have something for you to test within the next couple weeks.

@FidelCapo
Copy link

So do you have any build for windows and OSX that you could send me?

@rockstorm101
Copy link
Collaborator

@FidelCapo
Copy link

Oh, sorry, I did not find it. Thank you

@FidelCapo
Copy link

I tested prints on win Pronterface build on MK2, MK3, MK2MM and MK2MM Single mode and all are ok. Error with command T in MM Single mode gcode did not reappear.

@FidelCapo
Copy link

Do you have any estimate of when you release final version? If you want, I can help with testing because I'm going to test Pronterface for us anyway.

@hroncok
Copy link
Collaborator

hroncok commented Mar 28, 2018

I suppose when no new bug will be opened for a ~week. Also #913 is open.

@bubnikv
Copy link
Author

bubnikv commented Mar 28, 2018

@hroncok

I suppose when no new bug will be opened for a ~week.
Don't be so harsh to yourself, look at the list of open issues at both slic3rs. With such a policy we would not make a release ever :-)

@hroncok
Copy link
Collaborator

hroncok commented Mar 28, 2018

Well here the traffic isn't that high. I suppose when no new regressions are reported was what I intended to say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants