Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py does not install plugins #834

Closed
diggit opened this issue Jul 8, 2017 · 5 comments
Closed

setup.py does not install plugins #834

diggit opened this issue Jul 8, 2017 · 5 comments

Comments

@diggit
Copy link

diggit commented Jul 8, 2017

Calling setup.py does not install plugins (whole directory missing) to their place. As result, pronterface.py does not start.

When running from cloned repository, pronterface.py starts normally.

Traceback (most recent call last):
  File "/usr/bin/pronterface.py", line 34, in <module>
    from printrun.pronterface import PronterApp
  File "/usr/lib/python2.7/site-packages/printrun/pronterface.py", line 32, in <module>
    from . import pronsole
  File "/usr/lib/python2.7/site-packages/printrun/pronsole.py", line 35, in <module>
    from . import printcore
  File "/usr/lib/python2.7/site-packages/printrun/printcore.py", line 41, in <module>
    from plugins import PRINTCORE_HANDLER
ImportError: No module named plugins
@kliment
Copy link
Owner

kliment commented Jul 8, 2017

@nexus511 can you do something about this?

@nexus511
Copy link
Contributor

nexus511 commented Jul 8, 2017

Looks you got a point there. Thank you for hinting me. I will take a look at it.

@nexus511
Copy link
Contributor

nexus511 commented Jul 8, 2017

Okay. To properly fix this, I will move the plugins directory into the printrun folder to ensure that it does not conflict with other site-packages.

I will implement this and provide a pull-request within the day. All in all it's not a big deal but might anyone using the plugin mechanism enforce to move her plugins once after updating. As I would guess that this is only me for now, I hope that this does not cause a lot of trouble.

nexus511 added a commit to nexus511/Printrun that referenced this issue Jul 8, 2017
This fix consists of two changes:
1. moving plugins to the printrun package
2. let setup.py also install printrun.plugins
kliment added a commit that referenced this issue Jul 8, 2017
fix: setup.py does not install plugins #834
@kliment
Copy link
Owner

kliment commented Jul 8, 2017

Fixed, thanks @nexus511

@kliment kliment closed this as completed Jul 8, 2017
@diggit
Copy link
Author

diggit commented Jul 8, 2017

Thanks for fast solution!

@rockstorm101 rockstorm101 removed 2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases Not a bug Question Waiting for feedback labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants