Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange of module pyreadline with pyreadline3 in requirements.txt #1332

Closed
DivingDuck opened this issue Mar 29, 2023 · 3 comments
Closed

Exchange of module pyreadline with pyreadline3 in requirements.txt #1332

DivingDuck opened this issue Mar 29, 2023 · 3 comments
Labels

Comments

@DivingDuck
Copy link
Collaborator

The module pyreadline seams to have no maintenance. By reviewing our latest latest build log I recognize a note in https://github.com/kliment/Printrun/actions/runs/4542190897/jobs/8005293012, line 107:

DEPRECATION: pyreadline is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559

There exists a new fork called pyreadline3 that seems to be maintained and solved some of the problems the original module had and solve as well the deprecation note.

Reference

pyreadline: pyreadline/pyreadline#76

pyreadline3: https://github.com/pyreadline3/pyreadline3

I integrated the new module in my repository for a couple of live prints and there was no problems so fare. So my suggestion is to switch to the new module.

Related to Windows build only

Please let me know what you are think about this @kliment, @rockstorm101

DivingDuck added a commit to DivingDuck/Printrun that referenced this issue Mar 29, 2023
@rockstorm101
Copy link
Collaborator

rockstorm101 commented Mar 30, 2023

Hi @DivingDuck, did you run your tests on pronterface or on pronsole? I would say the readline module is more critical on the latter, so a successful run on pronsole would indicate whether they are truly interchangeable?

@DivingDuck
Copy link
Collaborator Author

Hi @rockstorm101, good point. I test it only on pronterface. I just start a needed little test print on pronsole and run monitor too.

@DivingDuck
Copy link
Collaborator Author

The print runs fine with pronsole and activated monitor too. Guess, I can send an update later this evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants