Workaround for Issue #88 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concurrent invocations of touch() or set() for the same session id can result in problems. Practically, this may happen when a browser concurrently loads multiple resources for the same site. This PR dis-allows concurrent calls to touch() or set() for the same session id by default, but provides options to over-ride this behavior.
|
🎉 This PR is included in version 3.1.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent invocations of
touch()orset()for the same sessionidcan result in problems. (See isssue 88).Practically, this may happen when a browser concurrently loads multiple resources for the same site/page.
The problem may be limited to projects backed by an SQLite db, but this has not yet been carefully tested;
prismaorexpress-sessionmay alternately / additionally be implicated.As a work-around for now, this PR dis-allows concurrent calls to
touch()orset()for the same sessionidby default - but provides options to over-ride this new behavior, in case there happen to be scenarios for which the "fix" proves more problematic than helpful.