Fix some unittests #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when I used this plugin I found a couple of bugs in dotnet implementation, mainly the unit tests where wrong because the commands that where assumed did not worked when you tried to execute them manually on my local machine. In the process I rewrote some stuff because I thought it makes more sense like this. And also tested the unit tests for other tools and found there also some bugs.
In the meanwhile I switched to another plugin for unittests.
I create this PR not to merge as is, but more like: If you find stuff in here that is useful for the project you can take it over, I don't mind if you just copy it from here in your own PRs. If you find nothing useful in here just close the PR.
Thanks for your work, it served me well back then :)