Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added heating operational time #60

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Added heating operational time #60

merged 1 commit into from
Sep 3, 2024

Conversation

mdr78
Copy link
Contributor

@mdr78 mdr78 commented Sep 30, 2023

Hi Krisjanis,

I am a bit unsure on the easiest way to test this with HA.

I have a working HA installation in a VM.
Any clues are appreciated, before I go cloning and hacking the VM.

Ray K

@klejejs
Copy link
Owner

klejejs commented Oct 15, 2023

Hi, @mdr78! Sorry for the delayed response.
This PR looks OK to me and there is nothing that seems wrong. Did this PR work as expected for you? I tried with my heat pump and unfortunately, I got nothing because my heat pump does not support that value, but if the example.py shows the expected value there, I think this is OK to merge. Please let me know! 😉

@mdr78 mdr78 force-pushed the main branch 5 times, most recently from 150dcfa to 5ec369d Compare September 3, 2024 09:23
Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
@mdr78 mdr78 force-pushed the main branch 2 times, most recently from 179b474 to c3d21d5 Compare September 3, 2024 09:41
@mdr78
Copy link
Contributor Author

mdr78 commented Sep 3, 2024

I can confirm that I have tested and it works perfectly.
It needed one small update.

Screenshot 2024-09-03 10 45 25 AM

@klejejs
Copy link
Owner

klejejs commented Sep 3, 2024

Looks good! 👍🏻

@klejejs klejejs merged commit 9de92be into klejejs:main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants