Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Change library scrypt.js to scryptsy #92

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Conversation

jimni1222
Copy link
Contributor

Proposed changes

Many people are experiencing errors when building because of scrypt.
Removed the dependency on scrypt.js and replaced it with scryptsy.

This change reflects the content of web3.js v1.2.1. Here are some links:
refer web3/web3.js#3051
refer web3/web3.js#2913
refer https://github.com/ethereum/web3.js/pull/2937/files

https://github.com/ethereum/web3.js/blob/v1.2.1/packages/web3-eth-accounts/src/scrypt.js

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

close #91

Further comments

I'm concerned about the impact of this PR and ran all the tests described in package.json.
The tests didn't reveal any issues but if you're concerned about this change, please tell me.

@jimni1222 jimni1222 requested a review from kjhman21 as a code owner September 3, 2019 02:03
@jimni1222 jimni1222 self-assigned this Sep 3, 2019
@jimni1222 jimni1222 merged commit 0d163bd into klaytn:dev Sep 3, 2019
@jimni1222 jimni1222 deleted the scrypt branch September 3, 2019 02:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency of scrypt.js
2 participants