This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Many people are experiencing errors when building because of scrypt.
Removed the dependency on scrypt.js and replaced it with scryptsy.
This change reflects the content of web3.js v1.2.1. Here are some links:
refer web3/web3.js#3051
refer web3/web3.js#2913
refer https://github.com/ethereum/web3.js/pull/2937/files
https://github.com/ethereum/web3.js/blob/v1.2.1/packages/web3-eth-accounts/src/scrypt.js
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
close #91
Further comments
I'm concerned about the impact of this PR and ran all the tests described in package.json.
The tests didn't reveal any issues but if you're concerned about this change, please tell me.