Skip to content

Commit

Permalink
simplify config more
Browse files Browse the repository at this point in the history
  • Loading branch information
klausi committed May 30, 2024
1 parent a8d26de commit 86b0d74
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 0 additions & 3 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ parameters:
- '#\Drupal calls should be avoided in classes, use dependency injection instead#'
# new static() is a best practice in Drupal, so we cannot fix that.
- "#^Unsafe usage of new static\\(\\)\\.$#"
# Drupal allows object property access to custom fields, so we cannot fix
# that.
- "#^Access to an undefined property Drupal\\\\#"
# We forgot to use return type hints on some interfaces, cannot be changed
# in stable 4.0.
# @todo use return type hints everywhere for 5.0.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ public function resolve(FileInterface $entity = NULL, $style, RefinableCacheable
$metadata->addCacheableDependency($access);
if ($access->isAllowed() && $image_style = ImageStyle::load($style)) {

// @phpstan-ignore-next-line
$width = $entity->width;
// @phpstan-ignore-next-line
$height = $entity->height;

if (empty($width) || empty($height)) {
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Traits/MockingTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ protected function setUpSchema($schema, $id = 'test', array $values = []): void
protected function createTestServer($schema, $endpoint, array $values = []): void {
$this->server = Server::create([
'schema' => $schema,
'name' => $this->randomGenerator->name(),
'name' => $this->randomMachineName(),
'endpoint' => $endpoint,
] + $values);

Expand Down

0 comments on commit 86b0d74

Please sign in to comment.