Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the python package #90

Merged
merged 3 commits into from
Dec 18, 2021
Merged

Update the python package #90

merged 3 commits into from
Dec 18, 2021

Conversation

klaasnicolaas
Copy link
Owner

This PR will do:

  • Remove the init from the main dataclass
  • Decode always the request response
  • Add extra tests for full 100% codecov coverage

@klaasnicolaas klaasnicolaas added enhancement Enhancement of the code, not introducing new features. refactor Improvement of existing code, not introducing new features. labels Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #90 (719aa7a) into master (9149c01) will increase coverage by 5.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #90      +/-   ##
===========================================
+ Coverage   94.94%   100.00%   +5.05%     
===========================================
  Files           4         4              
  Lines         178       179       +1     
  Branches       29        34       +5     
===========================================
+ Hits          169       179      +10     
+ Misses          7         0       -7     
+ Partials        2         0       -2     
Impacted Files Coverage Δ
omnikinverter/omnikinverter.py 100.00% <100.00%> (+13.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9149c01...719aa7a. Read the comment docs.

@klaasnicolaas klaasnicolaas merged commit 3ff9e85 into master Dec 18, 2021
@klaasnicolaas klaasnicolaas deleted the klaas-2021-001 branch December 28, 2021 12:37
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features. refactor Improvement of existing code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant