Wrap TCP request reading in async_timeout.timeout()
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 357 362 +5
Branches 57 60 +3
=========================================
+ Hits 357 362 +5
☔ View full report in Codecov by Sentry. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
There have recently been [reports of `RuntimeError: coroutine ignored GeneratorExit`] which are presumably triggered by timeouts on the socket, without being raised as `TimeoutError`. This case seems to be mitigated by timing out the request after a default of 10 seconds which doesn't give `GeneratorExit` - triggered by something yet unknown - enough time to surface. [reports of `RuntimeError: coroutine ignored GeneratorExit`]: robbinjanssen/home-assistant-omnik-inverter#116
klaasnicolaas
approved these changes
May 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: robbinjanssen/home-assistant-omnik-inverter#116
Resubmit of #207, which I cannot reopen as non-collaborator.
There have recently been reports of
RuntimeError: coroutine ignored GeneratorExitwhich are presumably triggered by timeouts on the socket, without being raised asTimeoutError. This case seems to be mitigated by timing out the request after a default of 10 seconds which doesn't giveGeneratorExit- triggered by something yet unknown - enough time to surface.