-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SOFAR 2200TL #311
Add support for SOFAR 2200TL #311
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 324 324
Branches 55 55
=========================================
Hits 324 324
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make a separate test with its own data fixture?
Done in b184a28 |
I tried using this library for my SOFAR inverter and noticed it was failing due to a space while parsing integer for the rated power substring it tries to read from the
myDeviceArray
string.I have fixed that issue, updated the test to test this edge case too, and also updated the documentation adding support for SOFAR 2200TL🥂
Error Log for reference: