Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new exception for JSON inverter models #31

Merged
merged 3 commits into from
Sep 19, 2021

Conversation

klaasnicolaas
Copy link
Owner

Tests have shown that inverters sometimes give 0 values for both day and total production, which results in peaks in the Home Assistant Energy dashboard. This PR adds a new exception for those using the JSON source.

  • Add exception for JSON source
  • Add pytest for covering the new code

@klaasnicolaas klaasnicolaas added the new-feature New features or request. label Sep 19, 2021
@klaasnicolaas klaasnicolaas changed the title Add new exception for JSON inverter model Add new exception for JSON inverter models Sep 19, 2021
@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #31 (d98ec26) into master (cac98a5) will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   90.97%   91.42%   +0.45%     
==========================================
  Files           4        4              
  Lines         133      140       +7     
  Branches       19       21       +2     
==========================================
+ Hits          121      128       +7     
  Misses          9        9              
  Partials        3        3              
Impacted Files Coverage Δ
omnikinverter/__init__.py 100.00% <100.00%> (ø)
omnikinverter/exceptions.py 100.00% <100.00%> (ø)
omnikinverter/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac98a5...d98ec26. Read the comment docs.

@klaasnicolaas klaasnicolaas merged commit 66492cf into master Sep 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2021
@klaasnicolaas klaasnicolaas deleted the wrong-value_exception branch December 28, 2021 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant