Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return none on empty values #30

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Return none on empty values #30

merged 3 commits into from
Sep 17, 2021

Conversation

klaasnicolaas
Copy link
Owner

This PR will do:

  • If the value is "" return a None
  • Update the test models
  • 📚 Update the documentation about Poetry

@klaasnicolaas klaasnicolaas added documentation Solely about the documentation of the project. enhancement Enhancement of the code, not introducing new features. labels Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #30 (58ae541) into master (e356b6a) will increase coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   90.55%   90.97%   +0.42%     
==========================================
  Files           4        4              
  Lines         127      133       +6     
  Branches       17       19       +2     
==========================================
+ Hits          115      121       +6     
  Misses          9        9              
  Partials        3        3              
Impacted Files Coverage Δ
omnikinverter/omnikinverter.py 78.94% <ø> (ø)
omnikinverter/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e356b6a...58ae541. Read the comment docs.

@klaasnicolaas klaasnicolaas merged commit cac98a5 into master Sep 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2021
@klaasnicolaas klaasnicolaas deleted the bug-fix branch December 28, 2021 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Solely about the documentation of the project. enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant