Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Ginlong/Solis Wifi stick (S3-WIFI-ST) #290

Closed
wants to merge 5 commits into from

Conversation

koyote
Copy link

@koyote koyote commented Nov 4, 2022

Fixes #289

It introduces a new source type called 'cgi' which can be used for the newer Wifi stick.

@MarijnS95
Copy link
Contributor

@koyote if you replace the header with Fixes #289 it'll auto-close the issue on successful merge!

@koyote koyote changed the title Add support for new Ginlong/Solis Wifi stick (S3-WIFI-ST) Fixes #289 Nov 4, 2022
@MarijnS95
Copy link
Contributor

@koyote Not the title, the first sentence in your PR description (sorry for using the unclear word "header" here).

@MarijnS95
Copy link
Contributor

Note that #247 is going to add support for alarm_value, which this will have to fill based on set_inner_by_id("webdata_alarm", inverterArr[7]); (CC @klaasnicolaas, pending which PR gets in first).

@koyote koyote changed the title Fixes #289 Add support for new Ginlong/Solis Wifi stick (S3-WIFI-ST) ( Nov 4, 2022
@koyote koyote changed the title Add support for new Ginlong/Solis Wifi stick (S3-WIFI-ST) ( Add support for new Ginlong/Solis Wifi stick (S3-WIFI-ST) Nov 4, 2022
@MarijnS95
Copy link
Contributor

Don't forget to add your device to the Supported models list in the README with the new data type, and change the On the tcp source type you can also find: section to mention temperature on your CGI backend :)

(Although I do not know if this is specific to your device, since they abused/reused the webdata_rate_p field for it...)

@koyote
Copy link
Author

koyote commented Nov 4, 2022

I've added the temperature and updated the README

README.md Outdated Show resolved Hide resolved
@klaasnicolaas klaasnicolaas added the new-feature New features or request. label Nov 11, 2022
@koyote
Copy link
Author

koyote commented Nov 13, 2022

Hi,

Is there anything other change needed to get this PR merged?

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Dec 13, 2022
@github-actions github-actions bot closed this Dec 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or request. stale There has not been activity on this issue or PR for quite some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for latest Ginlong/Solis wifi stick (S3-WIFI-ST)
3 participants