Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Device info #23

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Add Device info #23

merged 4 commits into from
Sep 3, 2021

Conversation

klaasnicolaas
Copy link
Owner

  • This PR will add the option to read the device information.

So for known, inverters with JSON source doesn't have signal quality information

@klaasnicolaas klaasnicolaas added the new-feature New features or request. label Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #23 (b6a3143) into master (a1239ef) will increase coverage by 2.92%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   87.62%   90.55%   +2.92%     
==========================================
  Files           4        4              
  Lines          97      127      +30     
  Branches       12       17       +5     
==========================================
+ Hits           85      115      +30     
  Misses          9        9              
  Partials        3        3              
Impacted Files Coverage Δ
omnikinverter/__init__.py 100.00% <100.00%> (ø)
omnikinverter/models.py 100.00% <100.00%> (ø)
omnikinverter/omnikinverter.py 78.94% <100.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1239ef...b6a3143. Read the comment docs.

@klaasnicolaas klaasnicolaas merged commit c1e1f49 into master Sep 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
@klaasnicolaas klaasnicolaas deleted the device-info branch December 30, 2021 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant