Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new data entities to dataclass model #16

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Conversation

klaasnicolaas
Copy link
Owner

  • Update the data model
  • Add new exception
  • Add extra pytest tests

@klaasnicolaas klaasnicolaas added enhancement Enhancement of the code, not introducing new features. new-feature New features or request. labels Aug 31, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16 (0d4a5f7) into master (0e3473e) will increase coverage by 5.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   81.39%   87.09%   +5.70%     
==========================================
  Files           4        4              
  Lines          86       93       +7     
  Branches       10       10              
==========================================
+ Hits           70       81      +11     
+ Misses         13        9       -4     
  Partials        3        3              
Impacted Files Coverage Δ
omnikinverter/__init__.py 100.00% <100.00%> (ø)
omnikinverter/exceptions.py 100.00% <100.00%> (ø)
omnikinverter/models.py 100.00% <100.00%> (+6.66%) ⬆️
omnikinverter/omnikinverter.py 76.47% <0.00%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3473e...0d4a5f7. Read the comment docs.

@klaasnicolaas klaasnicolaas merged commit 3742080 into master Aug 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2021
@klaasnicolaas klaasnicolaas deleted the update-datamodel branch September 17, 2021 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features. new-feature New features or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants