Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor package for better model naming #441

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

klaasnicolaas
Copy link
Owner

@klaasnicolaas klaasnicolaas commented Jul 9, 2024

Proposed change

A 2nd refactor on this package, sorry!

Autarco's API is structured in a different way, which led to quite a bit of confusion as to which name we could best apply to models. With this refactor I have tried to bring some clarity to this.

Additional information

  • This PR fixes or closes issue: fixes #

Checklist

  • I have updated the documentation if needed.
  • I have updated the tests if needed.

@klaasnicolaas klaasnicolaas added breaking-change A breaking change for existing users. refactor Improvement of existing code, not introducing new features. labels Jul 9, 2024
@klaasnicolaas klaasnicolaas merged commit 8ab865a into main Jul 9, 2024
25 checks passed
@klaasnicolaas klaasnicolaas deleted the klaas-2024-003 branch July 9, 2024 14:22
@klaasnicolaas klaasnicolaas changed the title Klaas 2024 003 Refactor package for better model naming Jul 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change A breaking change for existing users. refactor Improvement of existing code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant