Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the package for Account / Location data #437

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

klaasnicolaas
Copy link
Owner

Proposed change

The package has been updated according to what Autarco's API returns today.

Retrieving the public_key has been changed to a get_account function with public_key attribute and the existing get_account function has been renamed to get_location.

Additional information

  • This PR fixes or closes issue: fixes #

Checklist

  • I have updated the documentation if needed.
  • I have updated the tests if needed.

@klaasnicolaas klaasnicolaas added breaking-change A breaking change for existing users. refactor Improvement of existing code, not introducing new features. labels Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2d3ecbc) to head (993981c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #437   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          132       138    +6     
  Branches        14        16    +2     
=========================================
+ Hits           132       138    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klaasnicolaas klaasnicolaas merged commit 04b60ad into main Jul 8, 2024
26 checks passed
@klaasnicolaas klaasnicolaas deleted the klaas-2024-002 branch July 8, 2024 19:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change A breaking change for existing users. refactor Improvement of existing code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant