Skip to content
This repository was archived by the owner on Jan 8, 2025. It is now read-only.

dev: use with_chain_id for CfgEnv #990

Closed
greged93 opened this issue Apr 20, 2024 · 5 comments · Fixed by #1209
Closed

dev: use with_chain_id for CfgEnv #990

greged93 opened this issue Apr 20, 2024 · 5 comments · Fixed by #1209
Labels
blocked Blocked right now for external reasons enhancement Enhancement of the code, not introducing new features. good first issue Good first issue for people wanting to contribute to this project.

Comments

@greged93
Copy link
Contributor

Describe the enhancement request
Once this PR is merged in revm, add the function with_chain_id in order to set the chain id of the config.

This needs to be updated in tracing/mod.rs in the new function of the Tracer.
@greged93 greged93 added enhancement Enhancement of the code, not introducing new features. good first issue Good first issue for people wanting to contribute to this project. labels Apr 20, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Apr 20, 2024
@greged93 greged93 mentioned this issue Apr 20, 2024
Merged
9 tasks
@jaipaljadeja
Copy link

hey is it up for grabs? i would like to take this. : )

@tcoratger
Copy link
Contributor

hey is it up for grabs? i would like to take this. : )

Assigned

@Pycomet
Copy link

Pycomet commented May 12, 2024

If this is still available, can i take it @tcoratger ?

@tcoratger
Copy link
Contributor

If this is still available, can i take it @tcoratger ?

Hey @Pycomet sorry but this issue is blocked until next release of reth when bluealloy/revm#1327 is included. And this issue is already assigned but feel free to pick another one and if you don't find one, stay tuned for the next one we release, happy to help :)

@greged93 greged93 added the blocked Blocked right now for external reasons label May 30, 2024
@Bosun-Josh121
Copy link

please assign

@tcoratger tcoratger mentioned this issue Jun 17, 2024
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Kakarot on Starknet Jun 18, 2024
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this issue Aug 9, 2024
@d-roak
ci: replace install katana commands with binary install (kkrt-labs#990)
b1fb581 
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/990)
<!-- Reviewable:end -->
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this issue Aug 9, 2024
@ClementWalter
Revert "ci: replace install katana commands with binary install (kkrt…
c0bd41e 
…-labs#990)"

This reverts commit b1fb581.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked Blocked right now for external reasons enhancement Enhancement of the code, not introducing new features. good first issue Good first issue for people wanting to contribute to this project.
Projects
No open projects
Kakarot on Starknet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use with_chain_id for CfgEnv tcoratger/kakarot-rpc
5 participants
@tcoratger @jaipaljadeja @greged93 @Bosun-Josh121 @Pycomet