-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixes/consistency improvements for multiline stuff #334
Conversation
thomcc
commented
Feb 12, 2020
- Movement::{BeginningOfLine,EndOfLine,etc} now actually go to beginning/end of the line.
- Movement::BeginningOfBuffer, etc was added to get the original functionality back.
- Fix some off-by-one bugs in the line movement code.
- Make it easier to test the multiline functionality by adding a matching bracket validator, and using it in the examples.
zsh seems to escape only '\n':
|
But zsh is buggy if line ends with a backslash: $ echo test\\
$ # a space is appended in history |
That part is just so that if you have a multiline history item, after saving/loading it doesn't come back as individual lines. Edit: Ah, nevermind, I misunderstood your point. I can rebase this this weekend. |
With bash, Ctrl-A/Ctrl-E|Ctrl-U/Ctrl-K moves|kills to begin/end of buffer even with multiline input. |
It's a mix with what does what -- fish-shell and... every text editor supporting these have it go to the beginning of the line. Also, as an anecdote: I use these very commonly and find going to the beginning of the buffer very frustrating (as it behaves differently than text editors). |
Ok. |
Anything left for this PR to get merged (except resolving conflicts of course)? We already use the code from the branch, and are pretty happy with it. |
Sorry, I was mistaken that I'd have time last weekend, but I have nothing else planned for this weekend/tomorrow afternoon and will rebase it. |
And introduce BeginningOfBuffer/EndOfBuffer as a replacement.
This should be good now. |
Thanks. |