Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vi mode (#94) #103

Merged
merged 79 commits into from
Aug 26, 2017
Merged

Vi mode (#94) #103

merged 79 commits into from
Aug 26, 2017

Conversation

gwenn
Copy link
Collaborator

@gwenn gwenn commented Dec 17, 2016

Still missing:

  • In Vi command mode, prevent user from going to end of line.

@kkawakam
Copy link
Owner

Sorry was on holiday, I'm taking a look at this now.

#[derive(Debug, Clone, PartialEq, Copy)]
pub enum Word {
// non-blanks characters
Big,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this called Big?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the term used at least by libedit, haskeline:

A "bigword" consists of: a maximal sequence of non-blanks preceded and followed by blanks

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay. Can you put that in as the comment?

src/keymap.rs Outdated
}

#[derive(Debug, Clone, PartialEq, Copy)]
pub enum Anchor {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can your provide comments here, out of context I don't know what this means/used for.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is used for yank, but a comment would help here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose this word because 'where' is a Rust keyword...
Any suggestion is welcome.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thats fine then.

@gwenn gwenn mentioned this pull request Jul 6, 2017
@kkawakam kkawakam merged commit 48e8d26 into kkawakam:master Aug 26, 2017
@gwenn gwenn deleted the vi-mode branch August 30, 2017 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants