Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MockWebServerExtension public and allow for server customization #532

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Make MockWebServerExtension public and allow for server customization #532

merged 1 commit into from
Dec 13, 2024

Conversation

sleberknight
Copy link
Member

@sleberknight sleberknight commented Dec 13, 2024 •
edited
Loading

  • Make MockWebServerExtension public. This is in preparation for
      most likely moving it to part of kiwi-test, i.e., in src/main
  • Add ability to customize the MockWebServer by using a
      Consumer
  • Add a builder. It currently only provides the ability to
      specify your own MockWebServer and the customization Consumer,
      but by using a builder instead of multiple constructors, it
      provides a nicer interface. The no-args constructor still
      exists for situations where no customization is needed.

@sleberknight
Make MockWebServerExtension public and allow for server customization
a3e84ce 
* Make MockWebServerExtension public. This is in preparation for
  most likely moving it to part of kiwi-test, i.e., in src/main
* Add ability to customize the MockWebServer by using a
  Consumer<MockWebServer>
* Add a builder. It currently only provides the ability to
  specify your own MockWebServer and the customization Consumer,
  but by using a builder instead of multiple constructors, it
  provides a nicer interface. The no-args constructor still
  exists for situations where no customization is needed.
@sleberknight sleberknight self-assigned this Dec 13, 2024
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Dec 13, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sleberknight sleberknight added this to the 3.7.1 milestone Dec 13, 2024
@sleberknight sleberknight merged commit d0f4433 into main Dec 13, 2024
6 checks passed
@sleberknight sleberknight deleted the enhance-MockWebServerExtension branch December 13, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@sleberknight