Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eventMap() method to InMemoryAppender #445

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Add eventMap() method to InMemoryAppender #445

merged 1 commit into from
Dec 17, 2023

Conversation

sleberknight
Copy link
Member

  • This method is copied from kiwi-beta, which has its own InMemoryAppender class. Eventually, this class can be made public and supersede that one.
  • Change from collect(toList()) in orderedEvents and orderedEventMessages to toList() as the terminal method. The returned lists should not be modifiable.

@sleberknight
Add eventMap() method to InMemoryAppender
d57608f 
* This method is copied from kiwi-beta, which has its own
  InMemoryAppender class. Eventually, this class can be made
  public and supersede that one.
* Change from collect(toList()) in orderedEvents and
  orderedEventMessages to toList() as the terminal method.
  The returned lists should not be modifiable.
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Dec 17, 2023
@sleberknight sleberknight added this to the 3.1.1 milestone Dec 17, 2023
@sleberknight sleberknight self-assigned this Dec 17, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sleberknight sleberknight merged commit bea2674 into master Dec 17, 2023
5 checks passed
@sleberknight sleberknight deleted the add-new-method-to-InMemoryAppender branch December 17, 2023 19:31
@sleberknight sleberknight modified the milestones: 3.1.1, 3.2.0 Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@sleberknight