Store capability values from CAP v3.2 handshakes + honor SASL v3.2 mechanism lists #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this is tracking available caps it seems it would be also wise for it to track cap-notify (CAP NEW|DEL) events to keep the list accurate |
|
Done (but not tested) |
So it can be retrieved later (eg. to know what SASL mechanisms are available). https://ircv3.net/specs/extensions/capability-negotiation.html#the-cap-ls-subcommand
From https://ircv3.net/specs/extensions/sasl-3.2#usage : > Clients SHOULD pick a mechanism present in the CAP LS reply they get from the server and attempt to use that mechanism for authentication after they request the sasl capability.
a284b41 to
74aa74a
Compare
progval
commented
Dec 13, 2022
|
forcing checks to re-run |
|
:) thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store capability values in 'CAP LS 302' negotiations.
So it can be retrieved later (eg. to know what SASL mechanisms are available).
https://ircv3.net/specs/extensions/capability-negotiation.html#the-cap-ls-subcommand
Honor SASL v3.2 mechanism lists
From https://ircv3.net/specs/extensions/sasl-3.2#usage:
Tested on The Lounge.