Allow disabling websocket_protocol by passing a falsy option (#316)

kiwiirc · Feb 17, 2022 · af14f5a · af14f5a
1 parent 2bc7f40
commit af14f5a
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/transports/websocket.js b/src/transports/websocket.js
@@ -20,7 +20,12 @@ module.exports = class Connection extends EventEmitter {
         this.incoming_buffer = '';
 
         this.protocol_fallback = false;
-        this.protocol = options.websocket_protocol;
+
+        // JSON does not allow undefined and websocket protocol does not allow falsy
+        // if the protocol is falsy then the user intends no protocol, so set to undefined
+        this.protocol = options.websocket_protocol ?
+            options.websocket_protocol :
+            undefined;
     }
 
     isConnected() {