-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow block_network.allowed_hosts configuration via fixture #82
Feature: Allow block_network.allowed_hosts configuration via fixture #82
Conversation
Yep, looks good to me! A small syntactic issue in the changelog Re: Werkzeug - I am ok with having this change here :) |
Thanks for bringing this change! :) |
Updated the changelog. ((Pycharm`s local history tried to revert your change suggestion 👀 )) |
Seems like another tox job requires pinning werkzeug |
Updated deps for failing tox job, also updated black version in |
Sorry, was a busy week and time flies... Updated PR, one test needed a |
Thanks! I'll take a look at codecov integration tomorrow |
8dbbb03
to
09904bc
Compare
Co-authored-by: Dmitry Dygalo <Stranger6667@users.noreply.github.com>
09904bc
to
200d585
Compare
Thank you @AndreCimander and sorry for the delay! |
@Stranger6667 no worries there, time is flying, thanks for the review and the merge! Wanted to rewrite the commit messages to satisfy conventional commits, but did not find the time to do it... |
Description
Extended
pytest_recording.plugin.block_network
to allow configuration of allowed_hosts viavcr_config
fixture.I had to version pin werkzeug<2.1.0 to avoid postmanlabs/httpbin#673, not sure if you would like to move this change to a separate PR :)
Checklist