Completing md5sum comparison and download #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the error message which appears without the change: ''' [INFO]: # Downloading recipes [INFO]: Downloading qt5 [DEBUG]: -> running mkdir -p /home/thopiekar/.local/share/python-for-android/packages/qt5 [INFO]: -> directory context /home/thopiekar/.local/share/python-for-android/packages/qt5 [DEBUG]: -> running basename http://download.qt.io/official_releases/qt/5.7/5.7.0/single/qt-everywhere-opensource-src-5.7.0.tar.gz [DEBUG]: qt-everywhere-opensource-src-5.7.0.tar.gz [WARNING]: Should check headers here! Skipping for now. Downloading qt5 from http://download.qt.io/official_releases/qt/5.7/5.7.0/single/qt-everywhere-opensource-src-5.7.0.tar.gz [DEBUG]: -> running rm -f .mark-qt-everywhere-opensource-src-5.7.0.tar.gz [INFO]: Downloading qt5 from http://download.qt.io/official_releases/qt/5.7/5.7.0/single/qt-everywhere-opensource-src-5.7.0.tar.gz [DEBUG]: -> running touch .mark-qt-everywhere-opensource-src-5.7.0.tar.gz Traceback (most recent call last): File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main "__main__", fname, loader, pkg_name) File "/usr/lib/python2.7/runpy.py", line 72, in _run_code exec code in run_globals File "/media/hdd/home/thopiekar/Projekte/GIT/thopiekar/python-for-android_fork/pythonforandroid/toolchain.py", line 837, in <module> main() File "/media/hdd/home/thopiekar/Projekte/GIT/thopiekar/python-for-android_fork/pythonforandroid/toolchain.py", line 834, in main ToolchainCL() File "/media/hdd/home/thopiekar/Projekte/GIT/thopiekar/python-for-android_fork/pythonforandroid/toolchain.py", line 489, in __init__ getattr(self, args.subparser_name.replace('-', '_'))(args) File "/media/hdd/home/thopiekar/Projekte/GIT/thopiekar/python-for-android_fork/pythonforandroid/toolchain.py", line 147, in wrapper_func build_dist_from_args(ctx, dist, args) File "/media/hdd/home/thopiekar/Projekte/GIT/thopiekar/python-for-android_fork/pythonforandroid/toolchain.py", line 190, in build_dist_from_args build_recipes(build_order, python_modules, ctx) File "pythonforandroid/build.py", line 540, in build_recipes File "pythonforandroid/recipe.py", line 342, in download_if_necessary File "pythonforandroid/recipe.py", line 385, in download UnboundLocalError: local variable 'current_md5' referenced before assignment '''
|
Oh, wait I'll finish the md5 comparison.. |
If the md5sum doesn't fit, the code will retry to compare the md5sum. If it still doesn't fit the code will exit(1) at the end.
|
Couldn't test against all cases, but should work now in most cases. |
|
Any questions/feedback left? |
|
Sorry for the delay reviewing, looks and works great. |
|
No problem 😉 Thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the error message which appears without the change: