Fix keyboard height issue #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily forcing Rect().top to always be 0.
|
where is the issue you are trying to solve? detail the version of kivy and py4a being used in the issue. |
|
@akshayaurora As i remember, @SapienTech was finding that the keyboard code permanently offset the kivy window. I didn't look into the issue, but does the solution seem reasonable to you? I'm not sure if forcing top to 0 is correct on all devices. |
|
@akshayaurora @inclement kivy is v1.9.1-dev , Buildozer is 0.31dev with the py4a it pulls by default. I agree with inclement that I'm not sure if this fix will work on all devices, but I have not heard any issues from the users of my app. |
akshayaurora
added a commit
that referenced
this pull request
Jan 10, 2016
Fix keyboard height issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the print lines to debug. It seems that mActivity.getWindow()... changes rctx.top to a non-zero number, which causes the app to permanently shift upwards . To replicate this error, make an app that calls the keyboard. The hotfix I added was to set rctx.top to zero.