-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements: relax version bound on "pep517" #2680
Merged
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "<0.7.0" bound was added in kivy@9f6d6fc to fix kivy#1994 : > The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was: > > ``` > ModuleNotFoundError: No module named \'pytoml\'\n' > ``` > > This ca be reproduced in local via: > > ```shell > pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv > ``` I think this no longer applies, `$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable` runs successfully for me, using latest `pep517==0.13.0`.
Fixes #2573 |
misl6
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for the CI to complete, but LGTM.
Thank you!
SomberNight
added a commit
to SomberNight/python-for-android
that referenced
this pull request
Oct 10, 2022
The "<0.7.0" bound was added in kivy@9f6d6fc to fix kivy#1994 : > The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was: > > ``` > ModuleNotFoundError: No module named \'pytoml\'\n' > ``` > > This ca be reproduced in local via: > > ```shell > pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv > ``` I think this no longer applies, `$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable` runs successfully for me, using latest `pep517==0.13.0`.
SomberNight
added a commit
to SomberNight/python-for-android
that referenced
this pull request
Oct 14, 2022
The "<0.7.0" bound was added in kivy@9f6d6fc to fix kivy#1994 : > The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was: > > ``` > ModuleNotFoundError: No module named \'pytoml\'\n' > ``` > > This ca be reproduced in local via: > > ```shell > pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv > ``` I think this no longer applies, `$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable` runs successfully for me, using latest `pep517==0.13.0`.
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Oct 18, 2022
The "<0.7.0" bound was added in kivy@9f6d6fc to fix kivy#1994 : > The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was: > > ``` > ModuleNotFoundError: No module named \'pytoml\'\n' > ``` > > This ca be reproduced in local via: > > ```shell > pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv > ``` I think this no longer applies, `$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable` runs successfully for me, using latest `pep517==0.13.0`.
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Jan 5, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc to fix kivy#1994 : > The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was: > > ``` > ModuleNotFoundError: No module named \'pytoml\'\n' > ``` > > This ca be reproduced in local via: > > ```shell > pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv > ``` I think this no longer applies, `$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable` runs successfully for me, using latest `pep517==0.13.0`.
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Jan 5, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc to fix kivy#1994 : > The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was: > > ``` > ModuleNotFoundError: No module named \'pytoml\'\n' > ``` > > This ca be reproduced in local via: > > ```shell > pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv > ``` I think this no longer applies, `$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable` runs successfully for me, using latest `pep517==0.13.0`.
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Jan 6, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc to fix kivy#1994 : > The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was: > > ``` > ModuleNotFoundError: No module named \'pytoml\'\n' > ``` > > This ca be reproduced in local via: > > ```shell > pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv > ``` I think this no longer applies, `$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable` runs successfully for me, using latest `pep517==0.13.0`.
shyamnathp
pushed a commit
to shyamnathp/python-for-android
that referenced
this pull request
Feb 17, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc to fix kivy#1994 : > The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was: > > ``` > ModuleNotFoundError: No module named \'pytoml\'\n' > ``` > > This ca be reproduced in local via: > > ```shell > pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv > ``` I think this no longer applies, `$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable` runs successfully for me, using latest `pep517==0.13.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "<0.7.0" bound was added in 9f6d6fc to fix #1994 :
I think this no longer applies,
$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable
runs successfully for me, using latestpep517==0.13.0
.Also, let's see if the CI tests pass.