Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call cython via the setuptools entrypoint, fixes #2311 #2312

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Call cython via the setuptools entrypoint, fixes #2311 #2312

merged 2 commits into from
Sep 14, 2020

Conversation

rambo
Copy link
Contributor

@rambo rambo commented Sep 11, 2020

As per #2311, the. running python -m Cython.Build.Cythonize is not the same thing as running cython

inclement
inclement approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks! I won't merge just yet in case someone else has an opinion, but the tests have passed so it should be fine.

@AndreMiras
Copy link
Member

Thanks for the PR. I also have nothing against it and test suite is happy

@tshirtman tshirtman merged commit 690dd18 into kivy:develop Sep 14, 2020
@rambo rambo deleted the issue-2311 branch September 14, 2020 10:43
vesellov pushed a commit to vesellov/python-for-android that referenced this pull request Feb 10, 2021
@rambo @vesellov
Call cython via the setuptools entrypoint, fixes kivy#2311 (kivy#2312)
1c93df7 
* Call cython via the setuptools entrypoint, refs kivy#2311

* Use the python_command way to invoke the cython cli entrypoint
germn pushed a commit to germn/python-for-android that referenced this pull request Mar 20, 2021
@rambo @germn
Call cython via the setuptools entrypoint, fixes kivy#2311 (kivy#2312)
819a1e6 
* Call cython via the setuptools entrypoint, refs kivy#2311

* Use the python_command way to invoke the cython cli entrypoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

@inclement inclement inclement approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rambo @AndreMiras @inclement @tshirtman