-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decode JAVA_NAMESPACE in _android.pyx #1747
Conversation
I'm also for that. (actually I'm patching it every time manually) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
It probably happens happens only on host python3 and pygame
bootstrap, right?
https://github.com/kivy/python-for-android/blob/0.7.0/pythonforandroid/recipes/android/__init__.py#L51
FWIW a similar issue got addressed here #1475 |
@AndreMiras , also on python3+sdl2 ( for me ) |
yeah, i'm pretty sure sdl2 is what's used in my build. And yeah i'm confused as well because the code for sdl2 for this declaration seems to make it an unicode string, but i still get the issue. |
merged, we'll see if that cause issues to others and learn more when that happens i guess. |
I gett an AttributeError after the change with python3 03-10 21:40:33.812 7532 7554 I python : File "android/_android.pyx", line 178, in init android._android |
Looks like we're gonna "learn more when that happens" soon 😄 |
This is a very bad idea. If this is broken, you can expect many others stuff to be broken as well (anybody that actually does the same concatenation). if JAVA_NAMESPACE is bytes, then it's just wrong no? I bet it's just about cython running with -3 or not |
I'm stuck at this for the whole day, it doesn't seem to fix by changing the _android.pyx (both occurrences) that I found inside the /.buildozer that is created inside my project's folder.
Yes, I am new to programming in general so I could have made a simple mistake or said some non-sense above. |
Just needed to use |
not sure why i need that if others don't, but i can't build anything depending on the android recipe without it.