Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix groestlcoin_hash recipe #1738

Merged
merged 2 commits into from
Mar 3, 2019
Merged

fix groestlcoin_hash recipe #1738

merged 2 commits into from
Mar 3, 2019

Conversation

tshirtman
Copy link
Member

apparently since the move to python3, the recipes can/should disable call_hostpython_via_targetpython.

AndreMiras
AndreMiras previously approved these changes Mar 3, 2019
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build just turned green. Conditional build happy, see log extract:

�[0K$ docker run -e CI p4a /bin/sh -c "$COMMAND"
[INFO]:    recipes modified: {'groestlcoin_hash'}
[INFO]:    recipes to build: {'groestlcoin_hash'}
[INFO]:    Found a single valid recipe set: ['hostpython3', 'libffi', 'openssl', 'sqlite3', 'python3', 'groestlcoin_hash']
[INFO]:    Trying to find a bootstrap that matches the given recipes.
[INFO]:    Found 3 acceptable bootstraps: ['webview', 'service_only', 'sdl2']
[INFO]:    Using the first of these: webview
[INFO]:    Found a single valid recipe set: ['hostpython3', 'libffi', 'openssl', 'sqlite3', 'python3', 'genericndkbuild', 'groestlcoin_hash', 'six', 'pyjnius', 'android']
[INFO]:    recipes to build (no broken): {'groestlcoin_hash'}
[INFO]:    requirements: python3,groestlcoin_hash
[INFO]:    -> directory context testapps/
...
...
�[1m[INFO]�[0m:    �[1m�[32m# Copying APK to current directory�[0m�[39m
�[1m[INFO]�[0m:    �[1m�[32m# APK filename not found in build output. Guessing...�[0m�[39m
�[1m[INFO]�[0m:    �[1m�[32m# Found APK file: /home/user/.local/share/python-for-android/dists/bdisttest_python3_googlendk/build/outputs/apk/debug/bdisttest_python3_googlendk-debug.apk�[0m�[39m
�[1m[INFO]�[0m:    # Add version number to APK
�[1m[INFO]�[0m:    # APK renamed to bdisttest_python3_googlendk-1.1-debug.apk
stty: 'standard input': Inappropriate ioctl for device
�[1m[INFO]�[0m:    �[90m->�[0m running cp /home/user/.local/share/python-for-android/dist...(and 133 more)�[0m
travis_time:end:06c0ef58:start=1551647035260745838,finish=1551647514299434432,duration=479038688594
�[0K�[32;1mThe command "docker run -e CI p4a /bin/sh -c "$COMMAND"" exited with 0.�[0m

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for removing that line.
BTW, you guys don't like git squashing do you? For such change I usually git add and then git commit --amend to avoid having two commits for a simple line change.
Could you squash on merge time then so we keep clean git history? 🙏

@tshirtman tshirtman merged commit 523d026 into master Mar 3, 2019
@tshirtman tshirtman deleted the fix/groestlcoin_hash branch March 3, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants