Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate android version code accounting for arch and min sdk #1720

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Generate android version code accounting for arch and min sdk #1720

merged 1 commit into from
Feb 25, 2019

Conversation

OptimusGREEN
Copy link
Contributor

Android version code is generated to account for the architecture it is built for as well as the minimum sdk.

The new version format is arch-minsdk-app version

This will allow apps of the same version name built for different architectures be uploaded to the play store and will provide separation for overlap.

example:
app version: 1.0.5
min sdk: 21

old style version code would be 10005 for all architectures

new version codes would be:
x86: 62110005
arm7: 72110005
arm8: 82110005

Android version code is generated to account for the architecture it is built for as well as the minimum sdk
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@inclement inclement merged commit abb4703 into kivy:master Feb 25, 2019
@j-devel
Copy link
Contributor

j-devel commented Feb 26, 2019

@OptimusGREEN I just found that apk build for x86_64 is failing:

  File "/home/a/.local/share/python-for-android/dists/unnamed_dist_1/build.py", line 368, in make_package
    arch_code = arch_dict[arch]
KeyError: u'x86_64'

Will x86_64 case be supported? 🤔

@OptimusGREEN
Copy link
Contributor Author

Hmmm, I wasn't aware that x86_64 was supported as Buildozer spec only offers the other 3 as arch options. The Android arch to build for, choices: armeabi-v7a, arm64-v8a, x86 @inclement we could always add this in if supported?

@inclement
Copy link
Member

@OptimusGREEN Go ahead, updating the buildozer.spec would be welcome. Thanks!

@OptimusGREEN
Copy link
Contributor Author

updated this to include x86_64 here #1733 and also spec here kivy/buildozer#839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants