[WIP][CORE UPDATE - PART XIV] Libtorrent+boost for both versions of python and updated versions #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2019
80aeb4f to
fea6e72
Compare
|
Looks good to me. @opacam would you mind rebasing one last time to resolve the conflicts? Otherwise I can do it and get someone else to merge it. The failing test is only because the log gets too long for travis. |
…tibility) Since the openssl and ndk update the boost and libtorrent recipes weren't working. The old version for boost libraries does not support openssl 1.1, so we must update it. The old libtorrent recipe is strongly dependant on boost so we also update it. Also, before this commit, the compiler used to make those builds were gcc, now we use clang (the default compiler for the latest android ndk). Note: Those recipes were tested for both python versions with a slight modification of the test apps and importing the libtorrent at runtime without problems, plus the generated libraries are linked with our versions of openssl and python (using the readelf command)
fea6e72 to
f551a85
Compare
|
Done @inclement |
inclement
approved these changes
Jan 30, 2019
|
Merged even though the tests aren't working, as they seem to fail repeatedly due to issues with downloading the SDK or its components. The tests passed before, and the PR doesn't touch any recipes that are actually in the tests, so it should be fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one more part for the pr #1537 (discussed previously in #1460 and #1534)
Grants compatibility for both versions of python, maintaining the same build method (android's ndk standalone toolchain and b2 tool) but now we will use clang as the compiler, plus starts the migration of the stl lib from gnustl_shared to c++_shared (the only one stl lib starting from ndk18)
Note: this has to be merged only when the core-update has been merged because it has been tested with the new python core and depends on the new openssl lib version 1.1 introduced in #1537