Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added argument that was lost during build.py merge #1533

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

inclement
Copy link
Member

This currently causes a crash if the minsdk and ndkapi don't match (in which case the missing argparse argument is accessed).

@ghost
Copy link

ghost commented Dec 16, 2018

oh sorry, I broke that 😬 😬 😬 haha. yeah, seems very reasonable to add it back 😂

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I broke it so I approve of @inclement unbreaking it 😄

@AndreMiras AndreMiras merged commit 6c41014 into kivy:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants