Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a new Kivy Launcher for Python 3 #1638

Closed
inclement opened this issue Jan 30, 2019 · 12 comments
Closed

Publish a new Kivy Launcher for Python 3 #1638

inclement opened this issue Jan 30, 2019 · 12 comments

Comments

@inclement
Copy link
Member

Issue created to mark this goal for the 2019 Belgium hackathon.

@KeyWeeUsr
Copy link
Contributor

New launcher is located here and the script for building setup.py. We need to find the key for signing the release.

Do we want to have both Python 2 and Python 3 launchers or just Python 3? Also, PyJNIus should have a release before this because there are important things fixed (ref counts, conversion between Python and Java, etc).

@inclement
Copy link
Member Author

I'd be happy to go with just Python 3, since it keeps the play store listings simple. Does the launcher need any testing I could do?

@KeyWeeUsr
Copy link
Contributor

I'm not sure there is any testing for the launcher necessary per se. It pretty much just runs a main.py file, but we need to check the services (e.g. service/main.py or something) actually works and/or launcher is at least compiled with --service ??? flag.

@AndreMiras
Copy link
Member

I feel like this issue should be tracked in https://github.com/kivy/kivy-launcher/issues but I couldn't transfer it to the kivy-launcher project somehow

@ghost
Copy link

ghost commented Apr 4, 2019

Does this thing replace the --launcher launcher? Because I have been meaning to look into removing that one due to licensing issues (uses the renpy source code in the source tree which has no license info and could be LGPL, which makes it a bit dangerous to keep around even if not used outside the launcher. Right now it might actually be copied into all apps even, I haven't investigated that yet)

It would be neat because then removing --launcher would be more feasible now. IMHO it is a great idea to have this as a separate external project, because I don't see how it couldn't use the normal bootstrap mechanism to start up

@chrysn
Copy link

chrysn commented Apr 4, 2019

The missing-license topic apart (that should be fixable if the actual source is tracked down), why would an LGPL file in the source be dangerous as long as it's properly declared? Python does not link, so even GPL requirements would only pertain to that file and not the "whole program", and with LGPL, it's even made explicit that this can be mixed with any license as long as the file stays LGPL.

@ghost
Copy link

ghost commented Apr 4, 2019

@chrysn I am not a lawyer, did you ask yours or did you just make that up?

Again I am not a lawyer so this is probably all nonsense, BUT:

  1. There is no way to swap it out easily in an .apk, that should be already a violation of the LGPL

  2. Nobody informs people of the LGPL license text and where to get the original source in their app, that is also a violation of the LGPL (or do you do that in your app?)

  3. Is a python import even regarded a dynamic link?

Python does not link,

Says who? the LGPL is written with C/C++ linking in mind, and while I get the argument python importing is similar to dynamic linking, did you actually ask someone competent about that? because just relying on a hunch here is a horrible idea

In overall the LGPL is just quite complicated to comply with, and on top of things the files are NOT properly declared right now. So I stick with my opinion that the only really sane option is to just rip them out.

@chrysn
Copy link

chrysn commented Apr 8, 2019

I am not a lawyer, did you ask yours or did you just make that up?

Neither am I, nor any of the options; my comment came from established practice in other projects, eg. what Debian accepts to be present in its binary packages.

I'd be happy to run through all those arguments, but before we waste both your and my time, is LGPL compatibility really the showstopper? And if so, do you have pointers to the possibly-offending files (for I didn't find them on a quick search but probably lacked the right parameters) to clarify their license? For if the renpy code should go out for technical reasons, or it turns out it's not as LGPL licensed as we imagine, continuing this would be interesting but pointless.

@ghost
Copy link

ghost commented Apr 8, 2019 via email

@chrysn
Copy link

chrysn commented Apr 8, 2019 via email

@ghost
Copy link

ghost commented Apr 8, 2019 via email

@Julian-O
Copy link
Contributor

Closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants