Display Java stacktrace by default in JavaException #696
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review @misl6 |
|
Gentle poke? |
|
I do think this would be a good addition to jnius. Any news? |
|
I'd be keen for a review on this @tshirtman @misl6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #203 and #623 we discussed printing the Java stacktrace by default, in order to assist developers with problems happenning within Java. This PR does this by overridding
__str__(), without trying to mock the Python traceback (which would be more elegant, but beyond my knowhow).Screenshot of how it looks like in Colab:
Screenshot of how it looks like from Python cmdline:
