Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade some Dependencies #880

Merged
merged 3 commits into from
Nov 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,15 @@
#################################
name: Lint Code Base

#
# Documentation:
# https://help.github.com/en/articles/workflow-syntax-for-github-actions
#

#############################
# Start the job on all push #
#############################
on:
push:
branches-ignore: [master, main]
# Remove the line above to run when pushing to master
#pull_request:
#branches: [master, main]
# Remove the line above to run when pushing to master or main
# pull_request:
# branches: [master, main]

###############
# Set the Job #
Expand All @@ -31,6 +26,14 @@ jobs:
# Set the agent to run on
runs-on: ubuntu-latest

############################################
# Grant status permission for MULTI_STATUS #
############################################
permissions:
contents: read
packages: read
statuses: write

##################
# Load all steps #
##################
Expand All @@ -39,17 +42,18 @@ jobs:
# Checkout the code base #
##########################
- name: Checkout Code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Full git history is needed to get a proper list of changed files within `super-linter`
# Full git history is needed to get a proper
# list of changed files within `super-linter`
fetch-depth: 0

################################
# Run Linter against code base #
################################
- name: Lint Code Base
uses: docker://ghcr.io/github/super-linter:slim-v4
uses: super-linter/super-linter/slim@v5
env:
VALIDATE_ALL_CODEBASE: false
DEFAULT_BRANCH: master
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DEFAULT_BRANCH: main
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
25 changes: 13 additions & 12 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,29 +1,30 @@
---
name: Run Gradle Push
on:
push:
branches: [ main ]
branches: [main]

jobs:
gradle:
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
- uses: actions/checkout@v4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering whether you add these formatting yourself or it has been done automatically from the IDE?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to fix some crazy warning by super linter. I would reduce it back.

Copy link
Collaborator Author

@iNoles iNoles Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to merge it and then fix it later?

- uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 8

- name: Gradle build
uses: gradle/gradle-build-action@v2
with:
arguments: build
- name: Gradle build
uses: gradle/gradle-build-action@v2
with:
arguments: build -x iosX64Test -x jsBrowserTest

- name: Publish to SNAPSHOT
uses: gradle/gradle-build-action@v2
env:
- name: Publish to SNAPSHOT
uses: gradle/gradle-build-action@v2
env:
SIGNING_KEY: ${{ secrets.SIGNING_KEY }}
SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }}
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
with:
with:
arguments: publishAllPublicationsToSonatypeRepository --max-workers 1
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
gradle:
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-java@v3
with:
distribution: temurin
Expand All @@ -14,4 +14,4 @@ jobs:
- name: Gradle build
uses: gradle/gradle-build-action@v2
with:
arguments: build
arguments: build -x iosX64Test -x jsBrowserTest
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
gradle:
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-java@v3
with:
distribution: temurin
Expand All @@ -16,7 +16,7 @@ jobs:
- name: Gradle build
uses: gradle/gradle-build-action@v2
with:
arguments: build
arguments: build -x iosX64Test -x jsBrowserTest

- name: Publish to MavenCentral
uses: gradle/gradle-build-action@v2
Expand Down
4 changes: 2 additions & 2 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
plugins {
kotlin("multiplatform") version "1.9.0" apply false
id("org.jetbrains.kotlinx.kover") version "0.7.2" apply false
kotlin("multiplatform") version "1.9.20" apply false
id("org.jetbrains.kotlinx.kover") version "0.7.4" apply false
}

val isReleaseBuild: Boolean
Expand Down
58 changes: 15 additions & 43 deletions fuel-kotlinx-serialization/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
plugins {
kotlin("multiplatform")
kotlin("plugin.serialization") version "1.9.0"
kotlin("plugin.serialization") version "1.9.20"
id("publication")
id("org.jetbrains.kotlinx.kover")
}
Expand All @@ -14,11 +14,11 @@ kotlin {
useJUnit()
}
}
js(IR) {
js {
browser()
binaries.executable()
}
ios {
iosArm64 {
binaries {
framework {
baseName = "Fuel-Serialization"
Expand All @@ -32,6 +32,13 @@ kotlin {
}
}
}
iosX64 {
binaries {
framework {
baseName = "Fuel-Serialization"
}
}
}
macosX64 {
binaries {
framework {
Expand All @@ -46,61 +53,26 @@ kotlin {
}
}
}

explicitApi()

sourceSets {
val commonMain by getting {
commonMain {
dependencies {
api(project(":fuel"))
api(libs.kotlinx.serialization.json)
api(libs.result)
}
}
val commonTest by getting {
commonTest {
dependencies {
implementation(kotlin("test"))
}
}
val jvmMain by getting
val jvmTest by getting {
jvmTest {
dependencies {
implementation(libs.mockwebserver)
}
}
val jsMain by getting
val jsTest by getting

val appleMain by creating {
dependsOn(commonMain)
}

val iosMain by getting {
dependsOn(appleMain)
}
val macosArm64Main by getting {
dependsOn(appleMain)
}
val macosX64Main by getting {
dependsOn(appleMain)
}
val iosSimulatorArm64Main by getting {
dependsOn(appleMain)
}

val appleTest by creating {
dependsOn(commonTest)
}

val iosTest by getting {
dependsOn(appleTest)
}
val macosArm64Test by getting {
dependsOn(appleTest)
}
val macosX64Test by getting {
dependsOn(appleTest)
}
val iosSimulatorArm64Test by getting {
dependsOn(appleTest)
}
}
}
2 changes: 1 addition & 1 deletion fuel-moshi-jvm/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ plugins {
kotlin("jvm")
id("publication")
id("org.jetbrains.kotlinx.kover")
id("com.google.devtools.ksp") version "1.9.0-1.0.11"
id("com.google.devtools.ksp") version "1.9.20-1.0.14"
}

kotlin {
Expand Down
53 changes: 22 additions & 31 deletions fuel/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ kotlin {
useJUnit()
}
}
js(IR) {
js {
browser()
binaries.executable()
}
ios {
iosArm64 {
binaries {
framework {
baseName = "Fuel"
Expand All @@ -31,6 +31,13 @@ kotlin {
}
}
}
iosX64 {
binaries {
framework {
baseName = "Fuel"
}
}
}
macosX64 {
binaries {
framework {
Expand All @@ -48,57 +55,41 @@ kotlin {

explicitApi()

targets.configureEach {
compilations.configureEach {
compilerOptions.configure {
freeCompilerArgs.add("-Xexpect-actual-classes")
}
}
}

sourceSets {
val commonMain by getting {
commonMain {
dependencies {
api(libs.kotlinx.coroutines.core)
}
}
val commonTest by getting {
commonTest {
dependencies {
implementation(kotlin("test"))
}
}

val jvmMain by getting {
jvmMain {
dependencies {
api(libs.okhttp.coroutines)
}
}
val jvmTest by getting {
jvmTest {
dependencies {
implementation(libs.mockwebserver)
}
}

val jsMain by getting {
/*dependencies {
api(npm("node-fetch", "2.6.1"))
api(npm("abort-controller", "3.0.0"))
}*/
}
val jsTest by getting

val appleMain by creating {
dependsOn(commonMain)
appleMain {
dependencies {
implementation(libs.okio)
}
}

val iosMain by getting {
dependsOn(appleMain)
}
val macosArm64Main by getting {
dependsOn(appleMain)
}
val macosX64Main by getting {
dependsOn(appleMain)
}
val iosSimulatorArm64Main by getting {
dependsOn(appleMain)
}
val iosTest by getting
}
}

Expand Down
11 changes: 5 additions & 6 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
[versions]
coroutines = "1.7.2"
jackson = "2.15.2"
coroutines = "1.7.3"
jackson = "2.15.3"
junit = "4.13.2"
moshi = "1.15.0"
okhttp = "5.0.0-alpha.11"
okio = "3.4.0"
okio = "3.6.0"
forge = "1.0.0-alpha3"
result = "5.4.0"
serialization = "1.5.1"
result = "5.5.0"
serialization = "1.6.0"

[libraries]
kotlinx-coroutines-core = { group = "org.jetbrains.kotlinx", name = "kotlinx-coroutines-core", version.ref = "coroutines" }
Expand All @@ -22,4 +22,3 @@ okio = { group = "com.squareup.okio", name = "okio", version.ref = "okio"}
forge = { group = "com.github.kittinunf.forge", name = "forge", version.ref = "forge" }
result = { group = "com.github.kittinunf.result", name = "result", version.ref = "result"}
result-jvm = { group = "com.github.kittinunf.result", name = "result-jvm", version.ref = "result"}

Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading