Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the pixel values as floating point numbers in Treemap #649

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

kitsuyui
Copy link
Owner

Problem

  • Currently the pixel values in the Treemap component are rounded to integers.
  • This causes gaps in the display when the pixel values are not rounded.

Solution

  • Keep the pixel values as floating point numbers in the Treemap component.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.02%. Comparing base (f28f36e) to head (8a807f1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   70.02%   70.02%           
=======================================
  Files          48       48           
  Lines        1715     1715           
  Branches      311      311           
=======================================
  Hits         1201     1201           
  Misses        514      514           
Flag Coverage Δ
unittests 70.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

 # Problem

- Currently the pixel values in the Treemap component are rounded to integers.
- This causes gaps in the display when the pixel values are not rounded.

 # Solution

- Keep the pixel values as floating point numbers in the Treemap component.
@kitsuyui kitsuyui force-pushed the fix-treemap-rounding branch from bd4ec6f to 8a807f1 Compare November 10, 2024 03:49
@kitsuyui kitsuyui merged commit 567bc24 into main Nov 10, 2024
25 checks passed
@kitsuyui kitsuyui deleted the fix-treemap-rounding branch November 10, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant