Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor package.json dependencies, peerDependencies, and devDependencies #299

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

kitsuyui
Copy link
Owner

@kitsuyui kitsuyui commented Jan 25, 2024

#298

  • Current dependencies might include packages that should ideally be peerDependencies. This can cause version conflicts for projects that consume my package.

…cies

- Current `dependencies` might include packages that should ideally be `peerDependencies`. This can cause version conflicts for projects that consume my package.
@kitsuyui kitsuyui force-pushed the cleanup-dependencies branch from 7f896b4 to 6abc674 Compare January 25, 2024 05:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d716fd) 68.99% compared to head (6abc674) 68.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   68.99%   68.99%           
=======================================
  Files          39       39           
  Lines        1329     1329           
  Branches      243      243           
=======================================
  Hits          917      917           
  Misses        412      412           
Flag Coverage Δ
unittests 68.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kitsuyui kitsuyui merged commit 9d8986c into main Jan 25, 2024
20 checks passed
@kitsuyui kitsuyui deleted the cleanup-dependencies branch January 25, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants